[Forwardport] magento/magento2#13498 issue #13497 - Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend\Image

[nmalevanec]

Original Pull Request

#13498 (created by @igortregub)

Included Commits

1. 220ad97

Fixed Issues (if relevant)

1. Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend returns image url with double slash #13497: Method getUrl in Magento\Catalog\Model\Product\Attribute\Frontend returns image url with double slash

Manual testing scenarios

1. Try to get product image via method getUrl from class Magento\Catalog\Model\Product\Attribute\Frontend\Image. Example(console command):

protected function execute(InputInterface $input, OutputInterface $output)
    {
        ObjectManager::getInstance()->get(State::class)->setAreaCode(Area::AREA_ADMINHTML);
        //Be sure, you have simple product with sku = "s1", and with image.
        $product = ObjectManager::getInstance()->get(ProductRepositoryInterface::class)->get('s1');
        $attributeRepository = ObjectManager::getInstance()->get(AttributeRepositoryInterface::class);
        $imageAttribute = $attributeRepository->get(4, 'image');
        $image = ObjectManager::getInstance()->get(\Magento\Catalog\Model\Product\Attribute\Frontend\Image::class);
        $image->setAttribute($imageAttribute);
        $output->writeln($image->getUrl($product));
    }

2. Check, image url has only single slashes ex: "http://domain/pub/media/catalog/product/t/e/test.jpg".

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
MAGETWO-87979 has been created to process this Pull Request

[orlangur]

@nmalevanec please rewrite branch so that original commit author is preserved (for example, with cherry pick)

[nmalevanec]

@orlangur, done.

[magento-engcom-team]

Hi @orlangur, thank you for the review.
MAGETWO-87979 has been created to process this Pull Request