Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change returning value for attribute option cretaion from 'true' to option record #14315

Closed
wants to merge 2 commits into from

Conversation

k-raputa
Copy link

Description

Fix for: Successful attribute option POST returns 'true', not the option hash or value

Fixed Issues (if relevant)

  1. Successful attribute option POST returns 'true', not the option hash or value #6300: Successful attribute option POST returns 'true', not the option hash or value

Manual testing scenarios

  1. POST an new option value using /V1/products/attributes/{attributeCode}/options. Request body looks like {"option": {"label": "FOOBAR"} }
  2. Response should contain new inserted option data

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 24, 2018

CLA assistant check
All committers have signed the CLA.

@mzeis
Copy link
Contributor

mzeis commented Mar 24, 2018

Hi @k-raputa, thanks for your PR!

It looks like #6300 and #8810 are duplicates. For #8810, there is a PR #12920 which is in review. I'll ping @okorshenko to decide what to do.

@mzeis mzeis requested a review from okorshenko March 24, 2018 12:46
@osrecio osrecio added the Event: distributed-cd Distributed Contribution Day label Mar 24, 2018
@mzeis
Copy link
Contributor

mzeis commented Mar 24, 2018

@k-raputa Please, also create PRs only from your personal fork and don't create branches in the M2 repository directly. Thank you!

@okorshenko
Copy link
Contributor

Please create the branch in your personal fork

@okorshenko okorshenko closed this Mar 29, 2018
@okorshenko okorshenko deleted the MAGETWO-57585 branch March 29, 2018 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Event: distributed-cd Distributed Contribution Day
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants