Allows modules with underscores in name to set custom a frontend_model in system.xml #14397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bentideswell, I have e couple of another PRs pending related to FQCN regexp, will process them soon including your one. |
sidolov
approved these changes
Aug 6, 2018
|
Hi @sidolov, thank you for the review. |
|
@bentideswell thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 8, 2018
…frontend_model in system.xml #14397
|
Hi @bentideswell. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is the same as this issue except that it applies to the system.xml file rather than layout XML files.
Description
Currently it's not possible to set a custom frontend_model value in system.xml if the module you're using has an underscore in the module name. This limit is put in place via a regular expression defined in the app/code/Magento/Config/etc/system_file.xsd file.
The supplied fix simply adds the underscore character to the regular expression.
Manual testing scenarios
To test simply create a configuration option that uses a custom frontend_model.