Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Allows modules with underscores in name to set custom a frontend_model in system.xml #17448

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Aug 8, 2018

Original Pull Request

#14397

This issue is the same as this issue except that it applies to the system.xml file rather than layout XML files.

Description

Currently it's not possible to set a custom frontend_model value in system.xml if the module you're using has an underscore in the module name. This limit is put in place via a regular expression defined in the app/code/Magento/Config/etc/system_file.xsd file.

The supplied fix simply adds the underscore character to the regular expression.

Manual testing scenarios

To test simply create a configuration option that uses a custom frontend_model.

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-2712 has been created to process this Pull Request

@orlangur orlangur self-assigned this Aug 8, 2018
@magento-engcom-team magento-engcom-team merged commit c007bda into magento:2.3-develop Aug 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Aug 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants