Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused namespace from Ui Export model #14834

Conversation

williankeller
Copy link
Member

Description

The Export model have some unused namespaces: Magento\Framework\Filesystem\Directory\WriteInterface.
Just removing it and update description

Manual testing scenarios

  1. For example, go to orders list;
  2. Export list of order by XML or CSV;
  3. All should export as expected.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@williankeller thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@larsroettig
Copy link
Member

Hi @williankeller, we can not accept this because you remove an interface for 2.2.
If you change the target branch to 2.3 we accept this.

http://devdocs.magento.com/guides/v2.0/contributor-guide/backward-compatible-development/#introduction-of-a-method-to-a-class-or-interface

http://devdocs.magento.com/guides/v2.2/extension-dev-guide/versioning/codebase-changes.html

best regards,

Lars

@larsroettig larsroettig self-requested a review April 24, 2018 19:10
@williankeller williankeller changed the base branch from 2.2-develop to 2.3-develop April 24, 2018 20:26
@williankeller williankeller changed the base branch from 2.3-develop to 2.2-develop April 24, 2018 20:27
@williankeller williankeller changed the base branch from 2.2-develop to 2.3-develop April 24, 2018 20:55
@williankeller
Copy link
Member Author

@larsroettig, Makes sense to me. Done! 😃

@magento-engcom-team
Copy link
Contributor

Hi @williankeller. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants