[Backport] Remove unused namespace from Ui Export model #13

[chirag-wagento]

Original Pull Request

#14834

Description

The Export model have some unused namespaces: Magento\Framework\Filesystem\Directory\WriteInterface.
Just removing it and update description

Manual testing scenarios

1. For example, go to orders list;
2. Export list of order by XML or CSV;
3. All should export as expected.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[chirag-wagento]

@mzeis Could you please check what cause failed travis?

Thanks,

[mzeis]

@chirag-wagento It looks like this only was a temporary problem with the internet connection. I restarted the build and now it passes.

[mzeis]

The current implementation (using WriteInterface) is correct. As you see in https://github.com/chirag-wagento/magento2/blob/a61a3763fe7093e413c7fee54a3eb20bd20003c9/lib/internal/Magento/Framework/Filesystem.php#L78, Magento returns a WriterInterface. What's actually passed might by a DirectoryList class which implements WriterInterface but it's best practice to use interfaces whenever possible.

[mzeis]

@chirag-wagento Please have a look if you agree with my code review (I tend to reject this PR). Thanks!

[chirag-wagento]

@mzeis
I was do auto generate this backport PR.So i don't know what is issue in code.

[mzeis]

@chirag-wagento Ok thanks! I will get feedback from the core team and inform you about what they say :)

[chirag-wagento]

@mzeis

Any update in this PR ?

Thanks

[mzeis]

@chirag-wagento Not yet, I am waiting for feedback.

[mzeis]

Hi @chirag-wagento! Unfortunately, I cannot accept your PR. #14834 was mistakenly accepted for 2.3-develop and later on reverted as part of #15692 for the reason stated above. This means that the change also will not be in 2.3.

Still, thank you for the time you have taken to create this PR!