Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo mistake in function comment #15302

Merged
merged 5 commits into from
May 20, 2018
Merged

Fixed typo mistake in function comment #15302

merged 5 commits into from
May 20, 2018

Conversation

sanganinamrata
Copy link
Member

Description

Changed word Unassign to Unassigned

Fixed Issues (if relevant)

N/A

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

orlangur
orlangur requested changes May 18, 2018
View reviewed changes
app/code/Magento/Theme/Model/Config.php Outdated
@@ -124,7 +124,7 @@ protected function _getAssignedScopesCollection($scope, $configPath)
}

/**
* Unassign given theme from stores that were unchecked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@orlangur orlangur self-assigned this May 18, 2018
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 20, 2018
@magento-engcom-team magento-engcom-team merged commit c4db071 into magento:2.2-develop May 20, 2018
magento-engcom-team pushed a commit that referenced this pull request May 20, 2018
ENGCOM-1599: Fixed typo mistake in function comment #15302
bd027a7
@magento-engcom-team
Copy link
Contributor

Hi @namratachangani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider porting this solution across release lines.
You may use Porting tool to port commits automatically.

This was referenced May 20, 2018
Closed
Closed
Merged
Merged
@sanganinamrata sanganinamrata mentioned this pull request May 21, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur requested changes

Assignees

@orlangur orlangur

@sidolov sidolov

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
May 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@sanganinamrata @magento-engcom-team @orlangur @sidolov