Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed typo mistake in function comment #15302

Merged
merged 5 commits into from
May 20, 2018
Merged

Fixed typo mistake in function comment #15302

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
48a8b1d
Fixed typo mistake in function comment
sanganinamrata May 18, 2018
1e1ceb9
Removed extra added space in function comment and fixed typo mistakes.
sanganinamrata May 18, 2018
298e392
Revert back file changes
sanganinamrata May 18, 2018
44031e0
Revert back file changes.
sanganinamrata May 18, 2018
c4db071
Merge branch 'ns-patch-8' of https://github.com/NamrataChangani/magen…
sanganinamrata May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/code/Magento/Paypal/Model/Api/Nvp.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,7 @@ public function callGetPalDetails()
}

/**
* Set Customer BillingA greement call
* Set Customer BillingAgreement call
*
* @return void
* @link https://cms.paypal.com/us/cgi-bin/?&cmd=_render-content&content_ID=developer/e_howto_api_nvp_r_SetCustomerBillingAgreement
Expand Down Expand Up @@ -1427,15 +1427,15 @@ protected function _deformatNVP($nvpstr)
$nvpstr = strpos($nvpstr, "\r\n\r\n") !== false ? substr($nvpstr, strpos($nvpstr, "\r\n\r\n") + 4) : $nvpstr;

while (strlen($nvpstr)) {
//postion of Key
//position of Key
$keypos = strpos($nvpstr, '=');
//position of value
$valuepos = strpos($nvpstr, '&') ? strpos($nvpstr, '&') : strlen($nvpstr);

/*getting the Key and Value values and storing in a Associative Array*/
$keyval = substr($nvpstr, $intial, $keypos);
$valval = substr($nvpstr, $keypos + 1, $valuepos - $keypos - 1);
//decoding the respose
//decoding the response
$nvpArray[urldecode($keyval)] = urldecode($valval);
$nvpstr = substr($nvpstr, $valuepos + 1, strlen($nvpstr));
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Theme/Model/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ protected function _getAssignedScopesCollection($scope, $configPath)
}

/**
* Unassign given theme from stores that were unchecked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

* Unassigned given theme from stores that were unchecked
*
* @param string $themeId
* @param array $stores
Expand Down