Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Wrong price amount on product page #11717 #15540

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

HirokazuNishi
Copy link
Contributor

Description

This PR fixes broken currency format for some locales.
Since Magento2.2, price in product pages were not shown as expected against integer currencies.

Fixed Issues (if relevant)

  1. Wrong price amount on product page #11717: Wrong price amount on product page

Manual testing scenarios

  1. Create store views for USD(or EUR) and JPY(or KRW, IDR, VND)
  2. Setup currency rates
  3. Create products
  4. Access frontend product page
  5. Price shown as expected format (ex. JPY, KRW, IDR, VND are integer currencies!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

@HirokazuNishi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @HirokazuNishi. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants