Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fix for Wrong price amount on product page #11717 #24

Merged
merged 217 commits into from
Jun 7, 2018

Conversation

gelanivishal
Copy link
Owner

Original Pull Request

magento#15540

Description

This PR fixes broken currency format for some locales.
Since Magento2.2, price in product pages were not shown as expected against integer currencies.

Fixed Issues (if relevant)

  1. Wrong price amount on product page magento/magento2#11717: Wrong price amount on product page

Manual testing scenarios

  1. Create store views for USD(or EUR) and JPY(or KRW, IDR, VND)
  2. Setup currency rates
  3. Create products
  4. Access frontend product page
  5. Price shown as expected format (ex. JPY, KRW, IDR, VND are integer currencies!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

scottsb and others added 30 commits November 16, 2017 14:43
…13328

 - Merge Pull Request magento#13328 from KarlDeux/magento2:issue/10346/Deadlock-in-OAuth
 - Merged commits:
   1. 521d11b
…2314

 - Merge Pull Request magento#12314 from scottsb/magento2:fix-layout-duplication
 - Merged commits:
   1. a97cc6d
Currently the setup upgrade is looping truth all order addresses and is the checking if the quote_address_id is empty. Changed this so that the collection contains only addresses where the quote_address_id is NULL.
…m/magento2ce into MAGETWO-84109-magento-magento2-12314
 - Merge Pull Request magento#15097 from dverkade/magento2:patch-23
 - Merged commits:
   1. 19c2ec7
…Gift Card used

 - Added math rounding for Reward Points balance
 - Fixed Gift Card account order comments history
 - Fixed Gift Card totals block
 - Added possibility to update totals for changed Store Credit during refund
…t from mini cart in IE11

- added fix for cart configuration page
 - Merge Pull Request magento#15305 from DanielRuf/magento2:chore/remove-extraneous-cursor-property
 - Merged commits:
   1. 32ca3e4
 - Fixed incorrect payment type for FedEx Smart Post Return request
 - Added possibility to parse multiple tracking codes for one Return request
…agento#15349

 - Merge Pull Request magento#15349 from neeta-wagento/magento2:feature-resolve-knockout-non-unique-id-console-error
 - Merged commits:
   1. 20d8e6a
   2. 3c8f6f4
magento-engcom-team and others added 29 commits June 5, 2018 02:51
 - Merge Pull Request magento#15789 from chirag-wagento/magento2:actions-toolbar-less-patch
 - Merged commits:
   1. 1cd748f
…code of undefined Dynamic data rows were failing due to a read after delete condition Rows were removed just before the information update. An undefined javascript error was triggered.
…ot read property source_… #14 magento#15840

 - Merge Pull Request magento#15840 from chirag-wagento/magento2:2.2-develop-PR-port-14805
 - Merged commits:
   1. 7d2d8cc
 - merged latest code from mainline branch
 - Merge Pull Request magento#15825 from NamrataChangani/magento2:nps-coding-fix-2
 - Merged commits:
   1. e5acc92
…r Wishlist module magento#15854

 - Merge Pull Request magento#15854 from rogyar/magento2:2.2-return-types-wishlist
 - Merged commits:
   1. 8bf7999
 - Merge Pull Request magento#15871 from DanielRuf/magento2:chore/remove-unused-less-import
 - Merged commits:
   1. ce6cc31
Accepted Public Pull Requests:
 - magento#15539: FIX fo rissue magento#15510 - First PDF download / export after login (by @phoenix128)
 - magento#15791: Removed unused class from forms less file. (by @chirag-wagento)
 - magento#15795: Remove double semicolon from the style sheets. (by @namratachangani)
 - magento#15734: [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento#15694: [Backport 2.2] Fix minor issues in ui export converter classes (by @dmytro-ch)
 - magento#12314: Prevent layout cache corruption in edge case (by @scottsb)
 - magento#15871: chore: remove unused less import (by @DanielRuf)
 - magento#15854: [Backport 2.2] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento#15840: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #14 (by @chirag-wagento)
 - magento#15825: Fixed set template syntax issue (by @namratachangani)
 - magento#15789: Removed unnecessary css. (by @chirag-wagento)
 - magento#15782: [Backport 2.2]Fix translations (by @VitaliyBoyko)


Fixed GitHub Issues:
 - magento#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento#15539 by @phoenix128 in 2.2-develop branch
   Related commits:
     1. 59e03c1

 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15734 by @hitesh-wagento in 2.2-develop branch
   Related commits:
     1. 67778cd
@gelanivishal gelanivishal merged commit ca0e89c into 2.2-develop Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.