Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed set template syntax issue #15825

Merged

Conversation

sanganinamrata
Copy link
Member

Description

I have added module name on a template file as per Magento standard coding format.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

I have changed all Magneto Bundle module template. so You can check after login on Magento Dashboard.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sanganinamrata
Copy link
Member Author

@chirag-wagento This pull request doesn't merge yet. Are you hurry to create forward/backword pull request?
I will create forward/backword pull request after merge my this request.

@magento-engcom-team
Copy link
Contributor

Hi @namratachangani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants