[Backport] Fixed set template syntax issue #16832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gelanivishal , please, revert extra changes from Magento/Bundle/Block/Catalog/Product/View/Type/Bundle/Option/Multi.php |
|
@sidolov I have reverted back changes as requested. Please review at once. |
|
Hi @gelanivishal. Thank you for your contribution. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 28, 2019
…it returns a store specific value even if there is no default value #23369
magento-engcom-team
added a commit
that referenced
this pull request
Aug 28, 2019
…op expedited Accepted Community Pull Requests: - #24253: Add tip for upper limit of the Email Text Length Limit field range (by @TomashKhamlai) - #24252: Correct the return of type of function _columnBrake in module-theme block topMenu.php (by @Krielkip) - #23369: #16832 - Reworked query in getAttributeRawValue so that it returns a store specific value even if there is no default value (by @semajeg) - #24249: Resolve Mass Delete Subscribers doesn't have "confirm" message issue24248 (by @edenduong) - #24242: "Save Product" with the invalid data must scroll to the error message issue24241 (by @edenduong) - #24341: Correct spelling (by @ravi-chandra3197) - #24327: Update Magento_AuthorizenetCardinal ReadMe (by @diazwatson) - #24328: Update Magento_AuthorizenetGraphQl ReadMe (by @diazwatson) - #24326: Update Magento_AuthorizenetAcceptjs Readme (by @diazwatson) - #24278: Update Magento_AsynchronousOperations ReadMe (by @diazwatson) - #24265: Correction in the shipping method if it is empty it no longer shows t� (by @wbeltranc) - #18678: Throw exception to prevent infinite loop caused by third party code. (by @convenient) Fixed GitHub Issues: - #24251: Module-Theme: TopMenu invalid type of value returned (reported by @Krielkip) has been fixed in #24252 by @Krielkip in 2.3-develop branch Related commits: 1. 60ea2be 2. e9dd493 - #16382: Product resource getAttributeRawValue function does not return anything if there is no default value (reported by @VincentMarmiesse) has been fixed in #23369 by @semajeg in 2.3-develop branch Related commits: 1. 01f1f15 2. 64184b3 3. 35c5185 4. 9ae33c8 5. 8c4bfa6 6. 7b0e528 7. c34f83c 8. 4d380bf 9. 540f03e - #24248: Mass Delete Subscribers doesn't have "confirm" message (reported by @edenduong) has been fixed in #24249 by @edenduong in 2.3-develop branch Related commits: 1. 01edbdc - #24241: "Save Product" with the invalid data must scroll to the error message (reported by @edenduong) has been fixed in #24242 by @edenduong in 2.3-develop branch Related commits: 1. 157e1cd - #19853: Shipping method undefined issue (reported by @namratavora) has been fixed in #24265 by @wbeltranc in 2.3-develop branch Related commits: 1. 10f880c 2. 775eab4 3. d8c8574 4. 86228e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15825
Description
I have added module name on a template file as per Magento standard coding format.
Fixed Issues (if relevant)
N/A
Manual testing scenarios
I have changed all Magneto Bundle module template. so You can check after login on Magento Dashboard.
Contribution checklist