Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] #14063 - Wrong invoice prefix in multistore setup due to default stor… #14

Merged
merged 1 commit into from
Jun 1, 2018

Conversation

gelanivishal
Copy link
Owner

@gelanivishal gelanivishal commented Jun 1, 2018

Original Pull Request

magento#15332

Set correct store id for Invoice

Description

I have taken correct store id from store object.

Fixed Issues (if relevant)

  1. Wrong invoice prefix in multistore setup due to default store id magento/magento2#14063: Wrong invoice prefix in multistore setup due to default store id
  2. ...

Manual testing scenarios

  1. Create Multiple Store View
  2. Place an order from different store view and create an invoice
  3. Check Invoice prefix for different store view

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sorry, something went wrong.

@gelanivishal gelanivishal merged commit 634b957 into 2.1-develop Jun 1, 2018
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018
…ot read property source_… #14 magento#15840

 - Merge Pull Request magento#15840 from chirag-wagento/magento2:2.2-develop-PR-port-14805
 - Merged commits:
   1. 7d2d8cc
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…ot read property source_… #14 magento#15840
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Accepted Public Pull Requests:
 - magento#15539: FIX fo rissue magento#15510 - First PDF download / export after login (by @phoenix128)
 - magento#15791: Removed unused class from forms less file. (by @chirag-wagento)
 - magento#15795: Remove double semicolon from the style sheets. (by @namratachangani)
 - magento#15734: [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento#15694: [Backport 2.2] Fix minor issues in ui export converter classes (by @dmytro-ch)
 - magento#12314: Prevent layout cache corruption in edge case (by @scottsb)
 - magento#15871: chore: remove unused less import (by @DanielRuf)
 - magento#15854: [Backport 2.2] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento#15840: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #14 (by @chirag-wagento)
 - magento#15825: Fixed set template syntax issue (by @namratachangani)
 - magento#15789: Removed unnecessary css. (by @chirag-wagento)
 - magento#15782: [Backport 2.2]Fix translations (by @VitaliyBoyko)


Fixed GitHub Issues:
 - magento#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento#15539 by @phoenix128 in 2.2-develop branch
   Related commits:
     1. 59e03c1

 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15734 by @hitesh-wagento in 2.2-develop branch
   Related commits:
     1. 67778cd
gelanivishal pushed a commit that referenced this pull request Oct 27, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Latest pull
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants