Fix #10687 - Product image roles disappearing

[Scarraban]

To fix #10687 - adds the 'types' key to the images array to provide existing image roles, which are reset after clearMediaAttribute() is called.

Description

This PR is to fix the issue outlined in #10687 - image roles being removed when saving by the ProductRepository.

Fixed Issues (if relevant)

1. Product image roles randomly disappear #10687: Product image roles randomly disappear

Manual testing scenarios

1. Initially save a product using the ProductRepostory, setting an image in the gallery with roles.
2. Save the product again, without setting the media gallery at all. Roles should persist after second save.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-2672 has been created to process this Pull Request

[magento-engcom-team]

@Scarraban thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[magento-engcom-team]

Hi @Scarraban. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

[michel334]

Hi @Scarraban. Any chance you have the fix for Magento version 2.2.3 ?

Magento 2.2.3 has no file
vendor\magento\module-catalog\Model\ProductRepository\MediaGalleryProcessor.php
but only
vendor\magento\module-catalog\Model\ProductRepository.php

[Scarraban]

Hi @michel334 ,

Check my replication steps comment on the issue #10687 - this was a patch fix that references the ProductRepository.php file before I made the pull request.

[michel334]

Thanks @Scarraban for the patch, it fixed our issue!