Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix #10687 - Product image roles disappearing #17553

Merged

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Aug 12, 2018

Original PR #15606

To fix #10687 - adds the 'types' key to the images array to provide existing image roles, which are reset after clearMediaAttribute() is called.

Description

This PR is to fix the issue outlined in #10687 - image roles being removed when saving by the ProductRepository.

Fixed Issues (if relevant)

  1. Product image roles randomly disappear #10687: Product image roles randomly disappear

Manual testing scenarios

  1. Initially save a product using the ProductRepostory, setting an image in the gallery with roles.
  2. Save the product again, without setting the media gallery at all. Roles should persist after second save.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: Catalog Release Line: 2.1 labels Aug 12, 2018
@eduard13 eduard13 requested a review from rogyar August 12, 2018 19:32
@VladimirZaets VladimirZaets self-assigned this Aug 12, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.16 milestone Aug 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-2750 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @eduard13. Thanks for the collaboration. Could you please fix the static test?

@eduard13
Copy link
Contributor Author

eduard13 commented Sep 1, 2018

Hi @VladimirZaets the failed test was fixed. But shouldn't we apply the same changes also for 2.2 and 2.3? Most probably for these versions, the same method has the same failing test.
Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your contribution.
We will aim to release these changes as part of 2.1.16.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants