-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ability to set is_visible_on_front to order status history comment #15637
Create ability to set is_visible_on_front to order status history comment #15637
Conversation
@markoshust thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
Thanks for this PR @markoshust I will start to process this for you now. |
…s history comment #15637
Hi @markoshust. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
i just had a quick question on how new releases work. it looks like the 2.2.6 branch is not re-merged into 2.3? so, any updates that are not separately merged into 2.3 are lost? |
@markoshust If a change has to be in 2.2.6 and 2.3 you have to create a Forwardport after it has been merged to 2.2-develop. The Porting Tool will help you doing this. |
Create ability to set is_visible_on_front to order status history comment.
Description
The parameter
is_visible_on_front
is able to be set from the admin, but not fromaddStatusHistoryComment
of the order model. This would provide the ability to set this value from custom code such as event observers.Manual testing scenarios
->addStatusHistoryComment($comment, false)
to not set is_visible_on_front (backwards compatible with no extra param)->addStatusHistoryComment($comment, false, true)
to set is_visible_on_front->addStatusHistoryComment($comment, false, false)
to not set is_visible_on_frontContribution checklist