Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Create ability to set is_visible_on_front to order status history comment #16846

Merged
merged 2 commits into from
Jul 16, 2018
Merged

[Backport] Create ability to set is_visible_on_front to order status history comment #16846

merged 2 commits into from
Jul 16, 2018

Conversation

ronak2ram
Copy link
Member

@ronak2ram ronak2ram commented Jul 16, 2018

Original Pull Request

#15637
Create ability to set is_visible_on_front to order status history comment.

Description

The parameter is_visible_on_front is able to be set from the admin, but not from addStatusHistoryComment of the order model. This would provide the ability to set this value from custom code such as event observers.

Manual testing scenarios

  1. Call ->addStatusHistoryComment($comment, false) to not set is_visible_on_front (backwards compatible with no extra param)
  2. Call ->addStatusHistoryComment($comment, false, true) to set is_visible_on_front
  3. Call ->addStatusHistoryComment($comment, false, false) to not set is_visible_on_front

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants