Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Create ability to set is_visible_on_front to order status history comment #16846

Merged
merged 2 commits into from
Jul 16, 2018
Merged

[Backport] Create ability to set is_visible_on_front to order status history comment #16846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
876315e
Create ability to set is_visible_on_front to order status history com…
markshust May 31, 2018
3fc48e9
Fixed according to Backward compatible development guide
Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions app/code/Magento/Sales/Model/Order.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,8 +993,24 @@ public function addStatusToHistory($status, $comment = '', $isCustomerNotified =
* @param string $comment
* @param bool|string $status
* @return OrderStatusHistoryInterface
* @deprecated
* @see addCommentToStatusHistory
*/
public function addStatusHistoryComment($comment, $status = false)
{
return $this->addCommentToStatusHistory($comment, $status, false);
}

/**
* Add a comment to order status history
* Different or default status may be specified
*
* @param string $comment
* @param bool|string $status
* @param bool $isVisibleOnFront
* @return OrderStatusHistoryInterface
*/
public function addCommentToStatusHistory($comment, $status = false, $isVisibleOnFront = false)
{
if (false === $status) {
$status = $this->getStatus();
Expand All @@ -1009,6 +1025,8 @@ public function addStatusHistoryComment($comment, $status = false)
$comment
)->setEntityName(
$this->entityType
)->setIsVisibleOnFront(
$isVisibleOnFront
);
$this->addStatusHistory($history);
return $history;
Expand Down