Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwardport] Feature space between category page #1 #15726

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Forwardport] Feature space between category page #1 #15726

merged 1 commit into from
Jun 21, 2018

Conversation

sanjay-wagento
Copy link
Contributor

Original Pull Request

#13026
A space between the category page and the main footer when applying specific settings

Description

Added some style to solve space issue on a category page with one column layout.

Fixed Issues (if relevant)

  1. A space between the category page and the main footer when applying specific settings #12601: A space between the category page and the main footer when applying specific settings

Manual testing scenarios

  1. Go to Content -> Blocks
  2. Add new block
  3. Block information:
    a. Enable block -> Yes
    b. Block title: Contact Us menu
    c. Identifier: contactusmenu
    d. Store View: All Store Views
    e. I am trying to create a contact us form on a cetegory page. I added the following content to the static block editor:
<p>{{block class="Magento\Contact\Block\ContactForm" template="Magento_Contact::form.phtml"}}</p>
<hr />
<p style="text-align: justify;">Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.</p>

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jun 4, 2018
@sanjay-wagento sanjay-wagento changed the title #12601 - A space between the category page and the main footer when a… Forwardport] Feature space between category page #1 Jun 4, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 20, 2018
@magento-engcom-team magento-engcom-team merged commit ce176d2 into magento:2.3-develop Jun 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sanjay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants