-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache of configuration files list #1628
Conversation
Looks like a great improvement to me. +1 |
Hi @otakarmare, this approach has no cache invalidation, and Reader is questionable place to implement this caching, also it looks inconstant with other methods - getComposerJsonFiles, getActionFiles |
Hi @otakarmare, cache invalidation should not be an issue, have a question about getComposerJsonFiles, getActionFiles methods, probably is it good idea to add caching for them too? |
Indeed cache invalidation doesn't seem like an issue because this cache is per-request. |
@vancoz I agree that getComposerJsonFiles, getActionFiles copy/paste part of logic with getConfigurationFiles and Magento/Framework/Module/Dir/Reader class has too many responsibilities, but it's another issue and I do not plan to do it in this pull request |
We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects. |
I sign CLA |
Can you please fix Travis builds? |
@otakarmare Can you please rebase onto the current develop branch and sign the licence cla agreement? Thanks! |
@otakarmare can you please merge the latest develop and restart builds? |
Internal ticket MAGETWO-50778 |
- MAGETWO-50778: [Github][PR] Add cache of configuration files list #1628 - Merge commit 'refs/pull/1628/head' of github.com:magento/magento2 into MAGETWO-50778 # Conflicts: # lib/internal/Magento/Framework/Module/Dir/Reader.php
- MAGETWO-50778: [Github][PR] Add cache of configuration files list #1628 - refactoring - extending solution and applying to get getComposerJsonFiles
- MAGETWO-50778: [Github][PR] Add cache of configuration files list #1628 - merge mainline
Public Pull Requests #11761 [BACKPORT 2.1] [TASK] Incorrect minimum memory_limit references have … by @lewisvoncken #11590 [Backport 2.1-develop] #11586 Fix duplicated crontab 2>&1 expression by @adrian-martinez-interactiv4 Fixed Public Issues #11322 User.ini files specify 768M - Docs recommend at least 1G #11586 Cron install / remove via command messes up stderr 2>&1 entries
Performance result: