Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cron install / remove via command messes up stderr 2>&1 entries #11586

Closed
adrian-martinez-interactiv4 opened this issue Oct 20, 2017 · 5 comments
Closed

Cron install / remove via command messes up stderr 2>&1 entries #11586

adrian-martinez-interactiv4 opened this issue Oct 20, 2017 · 5 comments
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@adrian-martinez-interactiv4
Copy link
Contributor

Installing or removing crontab via command adds 2>&1 repeatedly, even for crontab entries not related with Magento, if they match a regular expression. See details below.

Preconditions

  1. Magento2 develop branch
  2. PHP 7.0.15

Steps to reproduce

  1. Set up a crontab entry like this one:
    captura de pantalla 2017-10-20 a las 19 28 45
  2. Run bin/magento cron:install
  3. Check crontab via crontab -l
  4. Run bin/magento cron:remove
  5. Check crontab via crontab -l

Expected result

  1. Magento crontab gets installed, then removed and external crontab entry remains as it is

Actual result

  1. After installed, additional 2>&1 gets added:
    captura de pantalla 2017-10-20 a las 19 29 31
  2. After removed, also additional 2>&1 gets added:
    captura de pantalla 2017-10-20 a las 19 30 04

This also applies to other Magento2 installations crontab entries:
captura de pantalla 2017-10-20 a las 4 16 56
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 20, 2017
This was referenced Oct 20, 2017
Merged
Merged
Merged
@magento-engcom-team
Copy link
Contributor

@adrian-martinez-interactiv4, thank you for your report.
We've created internal ticket(s) MAGETWO-82533 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 23, 2017
okorshenko pushed a commit that referenced this issue Oct 24, 2017
@orlangur
MAGETWO-82461: #11586 Fix duplicated crontab 2>&1 expression #11587
72bb121 
 - Merge Pull Request #11587 from adrian-martinez-interactiv4/magento2:FR#CRON-INSTALL-PARSE-STDERR
 - Merged commits:
   1. 7c54e6d
okorshenko pushed a commit that referenced this issue Oct 24, 2017
MAGETWO-82461: #11586 Fix duplicated crontab 2>&1 expression #11587
788d5ed
okorshenko pushed a commit that referenced this issue Oct 24, 2017
Merge pull request #1607 from magento-engcom/develop-prs
c6e891d 
#11546 Add AuthenticationInterface to the public API by @navarr
#11659 [TASK] Removed Typo in Paypal TestCase didgit => digit by @lewisvoncken
#11649 #7915: customer objects are equal to eachother after observing event customer_save_after_data_object by @RomaKis
#11587 #11586 Fix duplicated crontab 2>&1 expression by @adrian-martinez-interactiv4
#11609 Fix a typo by @ajpevers
#11582 M2 11581 by @tzyganu
#11452 #11328 : app:config:dump adds extra space every time in multiline array value by @adrian-martinez-interactiv4
#11457 Added carrier code to ID to distinguish shipping methods [port 2.3] by @peterjaap
#10769 Fix: Keep packages sorted by @localheinz
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82461

okorshenko pushed a commit that referenced this issue Oct 24, 2017
@orlangur
MAGETWO-82463: [Backport 2.2-develop] #11586 Fix duplicated crontab 2…
bee85e6 
…>&1 expression #11591

 - Merge Pull Request #11591 from adrian-martinez-interactiv4/magento2:FR22#CRON-INSTALL-PARSE-STDERR
 - Merged commits:
   1. 4c4694d
okorshenko pushed a commit that referenced this issue Oct 24, 2017
MAGETWO-82463: [Backport 2.2-develop] #11586 Fix duplicated crontab 2…
2e27b70 
…>&1 expression #11591
okorshenko pushed a commit that referenced this issue Oct 24, 2017
Merge pull request #1613 from magento-engcom/2.2-develop-prs
2cc846e 
Public Pull Requests

#11591 [Backport 2.2-develop] #11586 Fix duplicated crontab 2>&1 expression by @adrian-martinez-interactiv4
#11561 Magento sets ISO invalid language code by @crissanclick
#11553 [2.2 Backport] ProductRepository sku cache is corrupted when cacheLimit is reached by @heldchen
#11439 [Backport 2.2-develop] #11328 : app:config:dump adds extra space every time in multiline array value by @adrian-martinez-interactiv4
#11510 Add interaction to admin:user:create command by @cmuench
#11522 [Backport 2.2-develop] Fix Filter Customer Report Review by @osrecio
#11499 Ensure database is cleared/Magento reinstalled when TESTS_CLEANUP is enabled by @joshuaswarren
#11385 Fix #10856: Sync billing with shipping address on Admin Order Page by @joni-jones
#11317 [Backport 2.2-develop] Send email to subscribers only when are new by @osrecio
@okorshenko
Copy link
Contributor

The issue has been fixed and delivered to 2.2-develop branch

@okorshenko okorshenko added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Oct 24, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82463

okorshenko pushed a commit that referenced this issue Oct 27, 2017
@orlangur
MAGETWO-82462: [Backport 2.1-develop] #11586 Fix duplicated crontab 2…
f7459ab 
…>&1 expression #11590

 - Merge Pull Request #11590 from adrian-martinez-interactiv4/magento2:FR21#CRON-INSTALL-PARSE-STDERR
 - Merged commits:
   1. 46cf1b6
   2. dde32da
   3. 4478cf4
okorshenko pushed a commit that referenced this issue Oct 27, 2017
MAGETWO-82462: [Backport 2.1-develop] #11586 Fix duplicated crontab 2…
808aac1 
…>&1 expression #11590
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@magento-team @okorshenko @adrian-martinez-interactiv4 @magento-engcom-team