Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] Use correct error message for duplicate error key in product import #16389

Merged

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jun 25, 2018

Original Pull Request

#15980

Description

During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the addRowError() call using the detailed error message.

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Relates to

#15980

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 25, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@gelanivishal gelanivishal changed the title Use correct error message for duplicate error key in product import [Backport 2.2] Use correct error message for duplicate error key in product import Jun 25, 2018
@ishakhsuvarov
Copy link
Contributor

Hi @gelanivishal
Please mention original Pull Request in the description when porting. This simplifies tracking of items which still require a port.

Thanks

@gelanivishal
Copy link
Contributor Author

@ishakhsuvarov I have updated. Please check it.

Thank you.

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
The changes from your Pull Request should be available with the upcoming 2.2.6 release.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants