Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct error message for duplicate error key in product import #15980

Merged
merged 2 commits into from
Jun 21, 2018
Merged

Use correct error message for duplicate error key in product import #15980

merged 2 commits into from
Jun 21, 2018

Conversation

denteblu
Copy link
Contributor

Description

During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the addRowError() call using the detailed error message.

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 10, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 11, 2018
@magento-engcom-team
Copy link
Contributor

@denteblu thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 78630e9 into magento:2.3-develop Jun 21, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 21, 2018
ENGCOM-1944: Use correct error message for duplicate error key in pro…
73a3438 
…duct import #15980
@magento-engcom-team
Copy link
Contributor

Hi @denteblu. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

This was referenced Jun 25, 2018
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Component: CatalogImportExport Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@denteblu @magento-cicd2 @magento-engcom-team @ishakhsuvarov