[Backport] Use correct error message for duplicate error key in product import #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added one more empty line
… when applying specific settings
…play after clicking link in email
…store setup due to default stor… magento#15821 - Merge Pull Request magento#15821 from sanjay-wagento/magento2:2.1-develop-PR-port-15332 - Merged commits: 1. 2fcaf53
- Merge Pull Request magento#16226 from tejash-wagento/magento2:2.1-develop-PR-port-16082 - Merged commits: 1. 39f6740
…store setup due to default store id (fix order increment id)
… option value price magento#15236 - Merge Pull Request magento#15236 from VitaliyBoyko/magento2:Add-price-calculation-improvement-for-product-option-value-price - Merged commits: 1. 11020c2
…ion message does not dis… magento#15860 - Merge Pull Request magento#15860 from rahul-kachhadiya/magento2:2.1-develop-PR-port-15247 - Merged commits: 1. 1839f97
…5727 - Merge Pull Request magento#15727 from sanjay-wagento/magento2:2.1-develop-PR-port-13026 - Merged commits: 1. 5e6abd5
…de characters in column names magento#15722 - Merge Pull Request magento#15722 from tdgroot/magento2:2.1-develop-PR-port-15197 - Merged commits: 1. 5111760
magento#15699 - Merge Pull Request magento#15699 from dmytro-ch/magento2:2.1-develop-PR-port-15477 - Merged commits: 1. db762d3 2. 488c8a9
…ackend) magento#15289 - Merge Pull Request magento#15289 from VitaliyBoyko/magento2:Naming-collision-in-Javascript-ui-registry-(backend)-to-2.2 - Merged commits: 1. e9b144f
… CSV magento#15287 - Merge Pull Request magento#15287 from VitaliyBoyko/magento2:12304-Handle-empty-incorrect-lines-in-a-language-CSV - Merged commits: 1. 81f2600 2. e8fc7b4
…restriction is enabled
…ion message does not dis… magento#15860
… option value price magento#15236
…store setup due to default stor… magento#15821
…de characters in column names magento#15722
[TSG] Backporting for 2.1 (pr55) (2.1.15)
…ento#16294 - Merge Pull Request magento#16294 from vgelani/magento2:2.1-develop-PR-back-15362 - Merged commits: 1. c708638
…ento#16287 - Merge Pull Request magento#16287 from chirag-wagento/magento2:overlapping-issue-backport - Merged commits: 1. c601b84
Accepted Public Pull Requests: - magento#16226: Navigation dropdown caret icon. (by @tejash-wagento) - magento#16294: Removed duplicate line and added comment on variable (by @vgelani) - magento#16255: magento#15255 unlock customer after password reset (by @vgelani) - magento#15727: [Backport] Feature space between category page (by @sanjay-wagento) Fixed GitHub Issues: - magento#15255: Customer who exceeded max login failures not able to login even after reset password (reported by @tizzyguy87) has been fixed in magento#16255 by @vgelani in 2.1-develop branch Related commits: 1. be0f9bc - magento#12601: A space between the category page and the main footer when applying specific settings (reported by @wd7080) has been fixed in magento#15727 by @sanjay-wagento in 2.1-develop branch Related commits: 1. 5e6abd5
…eate and login form magento#16297 - Merge Pull Request magento#16297 from dankhrapiyush/magento2:2.1-develop-PR-16192 - Merged commits: 1. 96af9cf 2. 5e58bac 3. 4ec83ec
…file. magento#16319 - Merge Pull Request magento#16319 from NamrataChangani/magento2:2.1-develop-PR-port-16183 - Merged commits: 1. b9d75e7
- Merge Pull Request magento#16325 from vgelani/magento2:2.1-develop-PR-port-16247 - Merged commits: 1. 85eae4f
…eate and login form magento#16297
… handlers bound by jquery twice magento#16281
Fixed issues: - DEVOPS-2632 Sample Data Builds Migrated from Bamboo
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#16325: [Backport] Fixed typo error (by @vgelani) - magento#16297: [Backport-2.1] Trim email address in customer account create and login form (by @dankhrapiyush) - magento#16264: [Backport] Fix duplicate element id issue. (by @chirag-wagento) - magento#16270: Refactor validate code in Tax module (by @vgelani) - magento#16319: [Backport] Correct sentence in comment section in class file. (by @namratachangani) - magento#16281: [Backport] Submitting search form (mini) with enter key fires event handlers bound by jquery twice (by @vgelani) Fixed GitHub Issues: - magento#6058: IE11 user login email validation fails if field has leading or trailing space (reported by @dnadle) has been fixed in magento#16297 by @dankhrapiyush in 2.1-develop branch Related commits: 1. 96af9cf 2. 5e58bac 3. 4ec83ec - magento#13415: Duplicated elements id in checkout page (reported by @angelo983) has been fixed in magento#16264 by @chirag-wagento in 2.1-develop branch Related commits: 1. c9e5239 - magento#15352: Reformat the javascript code as per magento standards. (reported by @namratachangani) has been fixed in magento#16270 by @vgelani in 2.1-develop branch Related commits: 1. 67a9e13 - magento#13793: Submitting search form (mini) with enter key fires event handlers bound by jquery twice (reported by @koenner01) has been fixed in magento#16281 by @vgelani in 2.1-develop branch Related commits: 1. 5064cb8
Accepted Public Pull Requests: - magento#16287: [Backport] Solve overlapping Issue on category page. (by @chirag-wagento) Fixed GitHub Issues: - magento#15213: Alignment & overlapping Issue on every Home page & category page of Hot Seller section (reported by @cnviradiya) has been fixed in magento#16287 by @chirag-wagento in 2.1-develop branch Related commits: 1. c601b84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15980
Description
During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the
addRowError()call using the detailed error message.Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist