[Backport] Use correct error message for duplicate error key in product import #16390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gelanivishal , this pull request does not fix the bug, the case still reproducing. The error message for the duplicated key during the import does not contain any placeholders for the paramaeters. |
|
@gelanivishal , I am closing this PR now due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15980
Description
During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the
addRowError()call using the detailed error message.Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist
Relates to
#15980