-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing showInStore attributes #16458
Conversation
Add missing showInStore attributes on Braintree configuration as there are some values that are changeable on store view (Title, Descriptors, merchant name override) and are not accessible from store view level.
Hi @aschrammel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @orlangur, thank you for the review. |
Hi @aschrammel. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
The port for 2.3 is already done in PR #16459 :) Thanks for your feedback and BR |
Accepted Public Pull Requests: - #16760: [Backport] Declare module namespace before template path in Magento_Sales and Magento_Paypal (by @mageprince) - #16759: [Backport] Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax (by @mageprince) - #16550: [Backport #16458] Add missing showInStore attributes (by @aschrammel)
Description
Add missing
showInStore
attributes on Braintree configuration as there are some values that are changeable on store view (title, descriptors, merchant name override) and are not accessible from store view level due to the missing store view level permission for the containing group.Braintree configuration offers the possibility to change following fields on store view level:
All the fields are correctly shown in default config and on website level, but when changing to storeview, nothing is shown at all when expanding Braintree section.
Fixed Issues (if relevant)
Manual testing scenarios
After applying the PR, the above mentioned fields in their respective groups are shown.
Contribution checklist