Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing showInStore attributes #16458

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

aschrammel
Copy link

Description

Add missing showInStore attributes on Braintree configuration as there are some values that are changeable on store view (title, descriptors, merchant name override) and are not accessible from store view level due to the missing store view level permission for the containing group.

Braintree configuration offers the possibility to change following fields on store view level:

  • Basic Braintree Settings => Title
  • PayPal through Braintree => Title
  • PayPal through Braintree => Override Merchant Name
  • Dynamic Descriptors => Name
  • Dynamic Descriptors => Phone
  • Dynamic Descriptors => URL

All the fields are correctly shown in default config and on website level, but when changing to storeview, nothing is shown at all when expanding Braintree section.

Fixed Issues (if relevant)

Manual testing scenarios

  1. Go to Stores => Configuration => Sales => Payment Methods
  2. Click "Configure" next to "Braintree" under "Recommended Solutions"
  3. All groups are shown
  4. Switch from "Default Config" to a random Store View
  5. Repeat step 2 - no groups are shown

After applying the PR, the above mentioned fields in their respective groups are shown.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Add missing showInStore attributes on Braintree configuration as there
are some values that are changeable on store view (Title, Descriptors,
merchant name override) and are not accessible from store view level.
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 29, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @aschrammel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2149 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @aschrammel. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@aschrammel
Copy link
Author

Hi @magento-engcom-team.

The port for 2.3 is already done in PR #16459 :)

Thanks for your feedback and BR

magento-engcom-team added a commit that referenced this pull request Jul 5, 2018
…16459

 - Merge Pull Request #16459 from e-conomix/magento2:2.3-develop
 - Merged commits:
   1. 75fb28c
magento-engcom-team added a commit that referenced this pull request Jul 13, 2018


 - Merge Pull Request #16550 from e-conomix/magento2:2.1-braintree-backport
 - Merged commits:
   1. 6d79c64
magento-engcom-team pushed a commit that referenced this pull request Jul 13, 2018
Accepted Public Pull Requests:
 - #16760: [Backport] Declare module namespace before template path in Magento_Sales and Magento_Paypal (by @mageprince)
 - #16759: [Backport] Declare module namespace before template path in Magento_Theme,  Magento_Newsletter and Magento_Tax (by @mageprince)
 - #16550: [Backport #16458] Add missing showInStore attributes (by @aschrammel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants