Declare module namespace before template path name #16515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
Declare module namespace before template path
|
|
|
Hi @mageprince. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @mageprince. Thank you for your contribution. |
This was referenced Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we override any core block to any custom module, It throws an error because it tries to find template file in the custom module if we do not declare module namespace before template path.
I tried to extend Block Magento\Sales\Block\Order\Creditmemo from my custom module.
1 exception(s): Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'form/newsletter.phtml' in module: 'Vendor_Module'Fixed Issues (if relevant)
Declare module namespace before template path name.
For example:
protected $_template = 'Magento_Customer::form/newsletter.phtml';Manual testing scenarios
Override any block file which content static template file path
Contribution checklist