Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax #16699

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax #16699

merged 3 commits into from
Jul 12, 2018

Conversation

mageprince
Copy link
Contributor

@mageprince mageprince commented Jul 10, 2018

Relates PR
#16515

Description

When we override any core block to any custom module, It throws an error because it tries to find template file in the custom module if we do not declare module namespace before template path.
I tried to extend Block Magento\Sales\Block\Order\Creditmemo from my custom module.

1 exception(s): Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'form/newsletter.phtml' in module: 'Vendor_Module'

Fixed Issues (if relevant)

Declare module namespace before template path name.
For example: protected $_template = 'Magento_Customer::form/newsletter.phtml';

Manual testing scenarios

Override any block file which content static template file path

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev
Copy link
Contributor

@magento-engcom-team combine 16700

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your request. I'm working on combining the pull requests for you

@ihor-sviziev ihor-sviziev self-assigned this Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

@mageprince all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-2273 has been created to process this Pull Request

@sidolov sidolov changed the base branch from 2.3-develop to 2.2-develop July 12, 2018 07:10
@sidolov sidolov changed the base branch from 2.2-develop to 2.3-develop July 12, 2018 07:10
@magento-engcom-team magento-engcom-team merged commit 6cb335d into magento:2.3-develop Jul 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 12, 2018
@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants