-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax #16699
Declare module namespace before template path in Magento_Theme, Magento_Newsletter and Magento_Tax #16699
Conversation
Hi @mageprince. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team combine 16700 |
Hi @ihor-sviziev. Thank you for your request. I'm working on combining the pull requests for you |
@mageprince all pull requests have been successfully combined together:
|
Hi @ihor-sviziev, thank you for the review. |
…_Theme, Magento_Newsletter and Magento_Tax #16699
Hi @mageprince. Thank you for your contribution. |
Relates PR
#16515
Description
When we override any core block to any custom module, It throws an error because it tries to find template file in the custom module if we do not declare module namespace before template path.
I tried to extend Block Magento\Sales\Block\Order\Creditmemo from my custom module.
1 exception(s): Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'form/newsletter.phtml' in module: 'Vendor_Module'
Fixed Issues (if relevant)
Declare module namespace before template path name.
For example:
protected $_template = 'Magento_Customer::form/newsletter.phtml';
Manual testing scenarios
Override any block file which content static template file path
Contribution checklist