Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not forcefully set area in template if it is already set, fixes #14968, fixes #13530 #16661

Closed
wants to merge 3 commits into from
Closed

fix: do not forcefully set area in template if it is already set, fixes #14968, fixes #13530 #16661

wants to merge 3 commits into from

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#15137

Description

This reverts the addition of the enforced area in d3aef7c which caused #14968 and introduced this regression

Fixed Issues (if relevant)

  1. Can't change the applied theme in 2.2.4 #14968: Can't change the applied theme in 2.2.4
  2. "Template file 'header.html' is not found" error while trying to save Design Configuration. #13530: "Template file 'header.html' is not found" error while trying to save Design Configuration.

Manual testing scenarios

  1. comment / disable line 117 in app/code/Magento/Theme/Model/Design/Config/Validator.php
  2. change theme in store view

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@DanielRuf DanielRuf closed this Jul 10, 2018
@DanielRuf DanielRuf reopened this Jul 10, 2018
@DanielRuf
Copy link
Contributor

Did you test if this is needed in 2.3? It does not seem so as there is no exception thrown.

@DanielRuf
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @DanielRuf, here is your Magento instance.
Admin access: https://i-16661-2-3-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@DanielRuf
Copy link
Contributor

Not reproducible in 2.3.

@DanielRuf DanielRuf closed this Jul 10, 2018
@mageprince mageprince deleted the mageprince-2.3-patch-pull-15137 branch July 11, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants