-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't change the applied theme in 2.2.4 #14968
Comments
Can verify, also experiencing this exact issue. |
Indeed, can confirm as well on a clean 2.2.4 installation. I can not reproduce this on a clean 2.2.3 installation, so it looks like this is a new bug in 2.2.4, yay! |
@sferreira-nicopu just adding myself to the conversation since we experienced the same issue yesterday after updating our Magento Commerce Cloud to this version |
I am seeing this issue as well but trying to update logo and save. |
+1
shouldn't we have this code instead ??
here a stacktrace :
|
getting the same fault. |
Hi gtlt, For this: core_config_data: https://www.magentochile.cl/blog/wikis-images/bug/core_config_data.jpg design_config_grid_flat: https://www.magentochile.cl/blog/wikis-images/bug/design_config_grid_flat.jpg |
Would be good to have some regression testing for such things to potentially prevent such issues. How can we help here with tests? |
@magentochile the class |
Hi, I also met the same problem |
Same issue. Applied the code from above but I don't expect this is final solution. When it will be fixed? |
Dear sirs, I think you have to look at: $this->area = isset($data['area']) ? $data['area'] : null; And trace it back as far as it goes ... now I'm setting up a Magento 2 store and I'm not letting go ... if I manage to finish the store, I'll follow up. Maybe see what he throws with a: and look what it throws ... what's in $data['area'] that says it Area is already set! |
Hm, if the class did not change did the interface or consumers change its usage? |
Trying to change theme in fresh Magento 2.2.4 threw error "Something went wrong while saving this configuration: Area is already set". Any fix yet? |
I'm too facing this issue on fresh install of magento 2.2.4 |
I experience the same issue on fresh install of 2.2.4 Not sure if this helps, but I CAN save the theme at the website level. The error only occurs for me at the store view level. Changing the theme and saving at the website level updates the store view's theme. |
Right, global and website level work but not the store view level. |
I am also having this issue. 2.2.4. I was able to get around it by changing the theme_id value in core_config_data table manually. No known side effects yet. |
Ive also start having this problem since I upgraded from 2.2.3 to 2.2.4 ... |
I'll give it a try and try some bisecting tomorrow since this seems to affect many users and we do not yet have a solution or the cause of this. |
Experiencing the same issue here Magento 2.2.4 |
Hey friends, I stopped at my work, and I took another look at the error. And I did the essay to add echo $this->area, but in the "throw new" and it gave me the following result: public function setForcedArea($templateId) And it gave me the result of: The area "adminhtml" is that I think you should not assign the area to what corresponds to the frontend template. Here is documentation of that: https://devdocs.magento.com/guides/v2.0/architecture/archi_perspectives/components/modules/mod_and_areas.html So what could be done a small fix, although it's not the right thing, could be like that (other than the "adminhtml" area): public function setForcedArea($templateId) Regards, Boris Durán R. |
This is the cause. git bisect bad
d3aef7c3eef658baa00d3233d0352b5fed0f1cbe is the first bad commit
commit d3aef7c3eef658baa00d3233d0352b5fed0f1cbe
Author: Andrii Meysar <andrii.meysar@transoftgroup.com>
Date: Wed Mar 21 18:16:42 2018 +0200
MAGETWO-89261: Template file 'header.html' is not found.
:040000 040000 7437b710bf3a7e2a357f9bfd71a6d488aa225812 9f8cf78d8757c7a8d1aa17ad0ec0b2ef6b433cf2 M app |
@ghermans you can accomplish this 2 or 3 different ways.
Good luck |
Thanks for the quick response and detailed feedback. |
Additional: for number 2 of @EzzyEcom, use this method: https://support.magento.com/hc/en-us/articles/360005484154 to apply this commit using composer. |
Hi Guys, Sorry, am a real newbie but have just spent a fair bit of money on having a Magento site designed for me in 2.2.5 and now I find I can't make any basic changes like logo for example which makes my site useless?? Does this happen often in Magento? I came over from Sellerdeck and now wishing I hadn't :-( |
@rowneybury most logos and images are database/admin configurations. Sorry @everyoneelse I know this topic is not related to this #15137 but I just had to help the next guy over. |
@EzzyEcom Thanks for the prompt reply. Unfortunately I don't have the funds to have a developer on retainer. I'm surprised that this issue was known about in version 2.2.4 yet is still a problem in 2.2.5?? Odd way to work. Thanks again for the reply |
@rowneybury #15137 fix sounds like had a hiccup when it comes to being deployed on 2.2.5, but as mentioned previously in here, this will be automatically added by deploy bots on 2.2.6 in roughly about 2 months from now, if my math is right. In the mean time, if your site was built leveraging Magento 2 modularity architecture by means of composer, then you can easily rollback version from 2.2.5 to 2.2.3 and go on for a while until 2.2.6 rolls out. The other option is to patch your current version by following this simple GIT / composer instructions, Create a patch for a Magento 2 Composer to add commit SHA ...e9cb4ef2 |
Thanks again, I do appreciate the help. I think I need to speak to the company who installed my Magento and see if they can roll it back to 2.2.3, sounds like the easiest option. I will click the link you provided for creating a patch but fear it will mean nothing to me! :-) Enjoy the rest of your weekend. |
Squashed commit of the following: commit db9fa53cce1c8042caf24c855cfc18d1d948a6b8 Author: Daniel Ruf <daniel@daniel-ruf.de> Date: Thu May 10 19:18:37 2018 +0200 fix: change unit test back to test for the setForcedArea method commit af6d5c137ff57b13fbd8d6c9e097f7455f67cf7e Author: Daniel Ruf <daniel@daniel-ruf.de> Date: Thu May 10 19:10:11 2018 +0200 fix: just set the area if it is not set commit 2fd7e5d84abcdea5306f2bd81dd44b86aaa970d7 Author: Daniel Ruf <daniel@daniel-ruf.de> Date: Thu May 10 16:55:35 2018 +0200 fix: do not expect setForcedArea in unit tests for Magento\Theme\Test\Unit\Model\Design\Config\Validator commit a1bf00c10d5fc01e5e592f38472b820141a47133 Author: Daniel Ruf <daniel@daniel-ruf.de> Date: Thu May 10 16:46:04 2018 +0200 fix: do not set forced area in template, fixes magento#14968
FYI I created patch that can be applied on Magento 2.2.5. Just use following URL: |
what a shame.... I am considering migrating to django / python |
Nice to see that you created a patch for it @ihor-sviziev 👍 |
@ghermans : Magento 2 doesn't do hotfix releases unfortunately. |
As @EzzyEcom is saying, this problem is still in 2.2.5 ? on production server it's a hassle to modify core code and fix it nor using a hotfix. |
Yes, it will be fixed in 2.2.6. |
This happens even in 2.2.5. Some people have provided the solution but this is a patch to the core and it's not considered a permanent solution. Hope community fixed this in the new version and release it soon. |
Please read the previous comments, this will be fixed in 2.2.6. The bot communicated a wrong date. |
Having same problem, can't save "default page title" in Content > Design > Configuration |
Please just upvote at the top, do not comment |
Hello Friends! I was taking a look into this issue today and noticed that this error only seems prevalent when attempting to change the theme in the Global Configuration itself. If you change the theme in the Store View specifically it will be inherited by the Website and Global Configurations. I tested this with fresh installations of Magento 2.2.5 across multiple domains and was consistently able to change the theme by editing the Store Configuration specifically. For example: In this case you would want to change the theme in the Store Configuration (First Row) which would then be inherited by the Website Configuration (Second Row) and Global Configuration (Third Row). I only experience this error when attempting to edit the Global Configuration (Third Row) directly. (Please note that rows are in reference to the provided screenshot only.) |
This is all already known, please see the previous comments and the linked PR. |
For those wo need a fix and can not update the entry in the database, see #14968 (comment) You need the patch from https://magento.com/tech-resources/download#download2224 as this is probably in your vendor directory (composer based installs). You can use composer-patches, also see https://support.magento.com/hc/en-us/articles/360005484154 And use this diff / patch: |
Hi @oroskodias why did you delete @hostep comment? |
He deleted his own comment as well, don't worry, it wasn't adding anything new to the discussion :) |
Preconditions
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: