fix: do not forcefully set area in template if it is already set, fixes #14968, fixes #13530 #16660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface, remove meaningless code
…status-search # Conflicts: # app/code/Magento/AsynchronousOperations/Api/Data/OperationSearchResultsInterface.php # app/code/Magento/AsynchronousOperations/Model/OperationRepository.php
…status-search # Conflicts: # app/code/Magento/AsynchronousOperations/Api/Data/OperationSearchResultsInterface.php # app/code/Magento/AsynchronousOperations/Model/OperationRepository.php
…dvanced-attributes
[borg] MAGETWO-86795: Admin Create Customer functional test fails
…e-advanced-attributes
Accepted Public Pull Requests: - #16459: [Forwardport] Add missing showInStore attributes (by @aschrammel) - #16521: [Forwardport : Changed password placeholder text in checkout page] (by @hitesh-wagento) - #16515: Declare module namespace before template path name (by @mageprince) - #16492: Remove the timezone from the date when retrieving the current month from a UTC timestamp. (by @michaelwylde) - #15624: [2.3] [improvement] Swatches LESS rewrite (by @Karlasa) Fixed GitHub Issues: - #16378: Wrong placeholder for password field in the checkout page (reported by @mohitka) has been fixed in #16521 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 386438d - #15940: Wrong end of month at Reports for Europe/Berlin time zone if month contains 31 day (reported by @Stepa4man) has been fixed in #16492 by @michaelwylde in 2.3-develop branch Related commits: 1. 2482579
Move MFTF tests from dev/tests/acceptance to app/code
… not clear generated code
Fixed issues: - MC-2338 3rd party library/dependency upgrade for 2.3 pre Alpha
- merged latest code from mainline branch
Accepted Public Pull Requests: - #16573: Setting deploy mode to production with --skip-compilation flag should� (by @gelanivishal) - #16546: Properly hyphenate "third-party" (by @ronak2ram) - #16537: Issue in adding the wishlist of "zero price" product (by @gelanivishal) - #16520: [Forwardport] fix: change "My Dashboard" to "My Account", fixes #16007 (by @DanielRuf) - #16504: [Forwardport] Admin controller product set save refactor (by @AnshuMishra17) - #16228: [Forwardport] #16079 translation possibility for moreButtonText (by @Karlasa) - #13501: [Improvement] Implement customer group grid on ui component (by @simpleadm) Fixed GitHub Issues: - #16479: Issue in adding the wishlist of "zero price" product. (reported by @Sathishkumar8731) has been fixed in #16537 by @gelanivishal in 2.3-develop branch Related commits: 1. 4cb997a - #16079: Need information about translating issue (Magento Swatches Js) (reported by @mageho) has been fixed in #16228 by @Karlasa in 2.3-develop branch Related commits: 1. abcded5 2. 988ef89
[thunder] MAGETWO-92986: Write Logs for Failed Process of Generating Factories in Extensions
2.3 develop
|
|
|
Hi @mageprince. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
By mistake created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#15137
Description
This reverts the addition of the enforced area in d3aef7c which caused #14968 and introduced this regression
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist