-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in adding the wishlist of "zero price" product. #16479
Comments
Hi @Sathishkumar8731. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
where @Sathishkumar8731 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hello @Sathishkumar8731, thank you for your report. |
@magento-engcom-team give me 2.2.0 instance. |
Hi @gelanivishal. Thank you for your request. I'm working on Magento 2.2.0 instance for you |
Hi @gelanivishal, here is your Magento instance. |
@Sathishkumar8731 Thank you. |
Hi, Thank you. |
@magento-engcom-team give me 2.2.4 instance. |
Hi @gelanivishal. Thank you for your request. I'm working on Magento 2.2.4 instance for you |
Hi @gelanivishal, here is your Magento instance. |
@Sathishkumar8731 Thank you. |
@gelanivishal, please make sure test product has price = '0'. I've corrected product data on https://i-16479-2-2-4.engcom.dev.magento.com/. You may try to reproduce this issue again with updated product. |
Yes. I got it and will work on it. |
@Sathishkumar8731 I have figured out the issue. Please create an instance in PR and check it. Thank you. |
Hi @Sathishkumar8731. Thank you for your report. The fix will be available with the upcoming 2.3.0 release. |
Hi @Sathishkumar8731. Thank you for your report. The fix will be available with the upcoming 2.2.7 release. |
Is there any suggestion of how to fix this in a site running < 2.2.7 ? A plugin approach does not work due to the |
@chris-pook If I understood your problem correctly, creating a composer patch with the 0fc1574 commit should do the trick without any customizations. |
Hello @Sathishkumar8731 Same issue accrued in magento 2.2.4 and for zero price downloadable product and it's come from the ConfiguredRegularPrice.php file , and i just made change bellow in
|
Preconditions
Steps to reproduce
Fatal error: Uncaught TypeError: Argument 1 passed to Magento\Catalog\Pricing\Price\ConfiguredOptions::getItemOptionsValue() must be of the type float, boolean given, called in /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/ConfiguredRegularPrice.php on line 74 and defined in /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/ConfiguredOptions.php:24 Stack trace: #0 /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/ConfiguredRegularPrice.php(74): Magento\Catalog\Pricing\Price\ConfiguredOptions->getItemOptionsValue(false, Object(Magento\Wishlist\Model\Item)) #1 /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/BasePrice.php(32): Magento\Catalog\Pricing\Price\ConfiguredRegularPrice->getValue() #2 /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/FinalPrice.php(44): Magento\Catalog\Pricing\Price\BasePrice->getValue() #3 /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/ConfiguredPrice.php(101): Mage in /opt/lampp/htdocs/SVEP4087/vendor/magento/module-catalog/Pricing/Price/ConfiguredOptions.php on line 24
Expected result
Actual result
The text was updated successfully, but these errors were encountered: