[Backport] Issue in adding the wishlist of "zero price" product #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento#16911 - Merge Pull Request magento#16911 from gelanivishal/magento2:2.1-develop-PR-port-14395 - Merged commits: 1. 3d27dff
… the Subtotal column in the Creditmemo email magento#17155 - Merge Pull Request magento#17155 from TomashKhamlai/magento2:fix-creditmemo-email-less-backport - Merged commits: 1. 48e9b1b
…e database when the quote is empty magento#16898 - Merge Pull Request magento#16898 from mage2pratik/magento2:2.1-develop-PR-port-16675 - Merged commits: 1. f9ccb51
…me email address.
…me email address.
…me email address.
…ontains default date "1/1/1970" instead of empty field.
…ries to register with sa magento#17182 - Merge Pull Request magento#17182 from gelanivishal/magento2:2.1-develop-PR-port-15272 - Merged commits: 1. ff550b4 2. 158e977 3. 7359a16 4. f49cf3d 5. f08d932
…onfig fixture. Set the schedule for every minute so that the job is scheduled regardless of the time when you run the test.
Uniform jquery variable to "$" as this javascript is partially using "jquery" and partially "$". The line 62 will cause an error in Internet Explorer if $ is not declared.
Accepted Public Pull Requests: - magento#16619: [Backport] Login with wishlist raise report after logout (by @ronak2ram) - magento#17179: [Backport] Fix newsletter subscription behaviour for registered customer. (by @mage2pratik) - magento#16911: [Backport] Fixed extends and removed unnecessary variables (by @gelanivishal)
- Merge Pull Request magento#17335 from DanielRuf/magento2:fix/remove-unused-id-2-1 - Merged commits: 1. 2ddec42
…y validator magento#17108 - Merge Pull Request magento#17108 from gelanivishal/magento2:2.1-develop-PR-port-13509 - Merged commits: 1. 727503d 2. 38e2133 3. 4148751
Accepted Public Pull Requests: - magento#17335: fix: remove unused ID (by @DanielRuf)
removed extraneous margin and compensated padding and set both to 0, which creates the same effect
…to#17379 - Merge Pull Request magento#17379 from gelanivishal/magento2:2.1-develop-PR-port-15936 - Merged commits: 1. ebdc7c3
Accepted Public Pull Requests: - magento#17379: [Backport] magento#15308 removed extraneous margin (by @gelanivishal) - magento#17108: [Backport] Use constant time string comparison in FormKey validator (by @gelanivishal) Fixed GitHub Issues: - magento#15308: extraneous margins on product list and product list items (reported by @DanielRuf) has been fixed in magento#17379 by @gelanivishal in 2.1-develop branch Related commits: 1. ebdc7c3
sreichel
pushed a commit
that referenced
this pull request
Aug 6, 2018
sreichel
pushed a commit
that referenced
this pull request
Sep 16, 2018
sreichel
pushed a commit
that referenced
this pull request
Sep 16, 2018
sreichel
pushed a commit
that referenced
this pull request
Oct 17, 2018
sreichel
pushed a commit
that referenced
this pull request
Oct 17, 2018
sreichel
pushed a commit
that referenced
this pull request
Nov 15, 2018
sreichel
pushed a commit
that referenced
this pull request
Nov 22, 2018
Karlasa clean up multiwishlist
sreichel
added a commit
that referenced
this pull request
Dec 13, 2018
Fixes phpstan where 1st parameter is entity_id and 2nd $product->getId() 115 Parameter #2 $value of method Magento\Catalog\Model\AbstractModel::loadByAttribute() expects array|string|null, int|null given.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16537
Description
Fixed add to wishtlist item which price is zero.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist