Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare module namespace before template path name #17172

Merged
merged 7 commits into from
Aug 1, 2018
Merged

Declare module namespace before template path name #17172

merged 7 commits into from
Aug 1, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 26, 2018

Description

When we override block history(Magento\Sales\Block\Order\History) to my custom module.
It throws an error and finding order/history.phtml in my custom module.
I tried to extend Block Magento\Sales\Block\Order\History from my custom module.

1 exception(s):
Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'order/history.phtml' in module: 'Vendor_Module' block's name: 'sales.order.history'

Fixed Issues (if relevant)

  1. Declare module namespace before template path name(Magento_Sales::order/history.phtml). #16484: Declare module namespace before template path name(Magento_Sales::order/history.phtml).

Manual testing scenarios

  1. I override history block
    <preference for="Magento\Sales\Block\Order\History" type="Vendor\Module\Block\Order\History" />

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Jul 27, 2018

@magento-engcom-team combine 17176 17177 17178

@magento-engcom-team
Copy link
Contributor

Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@mage2pratik all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants