-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare module namespace before template path name #17172
Merged
magento-engcom-team
merged 7 commits into
magento:2.1-develop
from
mage2pratik:module-namespace-before-template-2
Aug 1, 2018
Merged
Declare module namespace before template path name #17172
magento-engcom-team
merged 7 commits into
magento:2.1-develop
from
mage2pratik:module-namespace-before-template-2
Aug 1, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@magento-engcom-team combine 17176 17177 17178 |
Hi @sidolov. Thank you for your request. I'm working on combining the pull requests for you |
This was referenced Jul 27, 2018
@mage2pratik all pull requests have been successfully combined together:
|
Hi @mage2pratik. Thank you for your contribution. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we override block history(Magento\Sales\Block\Order\History) to my custom module.
It throws an error and finding order/history.phtml in my custom module.
I tried to extend Block Magento\Sales\Block\Order\History from my custom module.
Fixed Issues (if relevant)
Manual testing scenarios
<preference for="Magento\Sales\Block\Order\History" type="Vendor\Module\Block\Order\History" />
Contribution checklist