Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] hide cookie notice instead of reloading site #17178

Closed
wants to merge 1 commit into from
Closed

[Backport] hide cookie notice instead of reloading site #17178

wants to merge 1 commit into from

Conversation

mage2pratik
Copy link
Contributor

Original Pull Request

#16890

Description

Instead of reloading the whole site when a use accepts the cookie notice, it should be accpetable to close the cookie notice only.

Manual testing scenarios

  1. Set Cookie Restricton Mode to 'Yes'
  2. Open the Homepage and click on 'Allow Cookies'
  3. The Cookie Notice will be closed immediately

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik
Thank you for your contribution. This pull request has been combined (merged) with #17172 to optimize pull requests queue on magento/magento2 repository
Closing this pull request.

@magento-engcom-team magento-engcom-team mentioned this pull request Jul 27, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Frontend Component: Cookie
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mage2pratik @magento-engcom-team @torhoehn