Skip to content

Commit

Permalink
Added int as input type
Browse files Browse the repository at this point in the history
Fixes phpstan where 1st parameter is entity_id and 2nd $product->getId()

  115    Parameter #2 $value of method
         Magento\Catalog\Model\AbstractModel::loadByAttribute() expects
         array|string|null, int|null given.
  • Loading branch information
sreichel authored and Sven Reichel committed Dec 13, 2018
1 parent b8892f0 commit d758b29
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/code/Magento/Catalog/Model/AbstractModel.php
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ public function getResourceCollection()
* Load entity by attribute
*
* @param \Magento\Eav\Model\Entity\Attribute\AttributeInterface|integer|string|array $attribute
* @param null|string|array $value
* @param null|string|int|array $value
* @param string $additionalAttributes
* @return bool|\Magento\Catalog\Model\AbstractModel
*/
Expand Down

0 comments on commit d758b29

Please sign in to comment.