Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed add to wishlist issue on product price 0 #17396

Closed

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 6, 2018

Description

Backport #16537

Fixed Issues (if relevant)

  1. Issue in adding the wishlist of "zero price" product.  #16479:Issue in adding the wishlist of "zero price" product

Manual testing scenarios

  1. Login as a customer in front end of the website.
    2, Open product with zero price
    2, Click on the wishlist button in the product

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Aug 6, 2018

Hi @sreichel , please, ensure that the issue #16479 reproduced on 2.1 release line, I see only two labels Reproduced applied.

@sreichel
Copy link
Contributor Author

sreichel commented Aug 6, 2018

@magento-engcom-team give me 2.1.15 instance

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your request.
Unfortunately, I can only deploy instances for 2.2 and 2.3 release lines

@sreichel
Copy link
Contributor Author

sreichel commented Aug 6, 2018

@sidolov I havent tested this with 2.1 (running PHP7.1), just checked the code for where getValue() is compared to ===false and found nothing.

How about change related unit tests to "zero price"?

Btw ... MAGETWO-73277 added same code to app/code/Magento/GroupedProduct/Pricing/Price/ConfiguredRegularPrice.php. Should this be fixed too?

@sidolov
Copy link
Contributor

sidolov commented Aug 7, 2018

@sreichel , fix unit test according to changes is a good idea

@sidolov
Copy link
Contributor

sidolov commented Aug 16, 2018

Hi @sreichel , we can't reproduce this issue on the latest 2.1-develop

Steps to reproduce:

  1. Log in as a customer in frontend of the website.
  2. Click on the wishlist button in the product.

Actual result:
The product is added to the wishlist.

17396

@sreichel
Copy link
Contributor Author

Closed due to lack of time.

@sreichel sreichel closed this Aug 16, 2018
@sreichel sreichel deleted the 2.1-develop-PR-port-16537 branch September 28, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants