Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed add to wishlist issue on product price 0 #17395

Merged

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 6, 2018

Description

Backport #16537

Fixed Issues (if relevant)

  1. Issue in adding the wishlist of "zero price" product.  #16479:Issue in adding the wishlist of "zero price" product

Manual testing scenarios

  1. Login as a customer in front end of the website.
    2, Open product with zero price
    3, Click on the wishlist button in the product

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sreichel sreichel changed the title Fixed add to wishlist issue on product price 0 [Backport] Fixed add to wishlist issue on product price 0 Aug 6, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.7 milestone Aug 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sreichel. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@sreichel sreichel deleted the 2.2-develop-PR-port-16537 branch August 10, 2018 17:11
@sreichel sreichel restored the 2.2-develop-PR-port-16537 branch August 10, 2018 17:12
@sreichel sreichel deleted the 2.2-develop-PR-port-16537 branch August 10, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants