Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] #15588 Fixed incorrect image urls in multistore xml sitemap #16813

Merged
merged 7 commits into from
Aug 10, 2018
Merged

[Forwardport] #15588 Fixed incorrect image urls in multistore xml sitemap #16813

merged 7 commits into from
Aug 10, 2018

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 14, 2018

Original Pull Request

#15689

Description

Added the appEmulation to get the correct image Url for the generated sitemaps. This was needed because the catalog image helper context had incorrect Url data.

Fixed Issues (if relevant)

  1. Images in XML sitemap are always linked to base store in multistore #15588: Images in XML sitemap are always linked to base store in multistore#15588

Manual testing scenarios

  1. In a multistore environment generate multiple sitemaps. Check if the image:loc has the correct base URL for set store.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

StevenGuapaBV and others added 7 commits July 14, 2018 17:29
Added the appEmulation to get the correct image Url for the generated sitemaps. Context had incorrect Url data.
 48 | ERROR | [x] Opening parenthesis of a multi-line function call must be the last content on the line
placed the stop Emulation in a finally. Now it will always be executed.
@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants