Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images in XML sitemap are always linked to base store in multistore #15588

Closed
dvershinin opened this issue May 29, 2018 · 2 comments
Closed

Images in XML sitemap are always linked to base store in multistore #15588

dvershinin opened this issue May 29, 2018 · 2 comments
Assignees
@StevenGuapaBV
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@dvershinin
Copy link

Preconditions

  1. Magento 2.2.3
  2. PHP 7.0.30
  3. MySQL: 5.6.37-82.2 Percona Server

Steps to reproduce

  1. Have a multistore Magento setup
  2. Configure each store to use their own domain
  3. Generate Magento XML sitemap

Expected result

  1. All images should be linked to corresponding store domain

Actual result

  1. All pages are linked to proper store but all images linked to base store

screenshot 2018-05-29 23 44 54
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 29, 2018
@dvershinin dvershinin changed the title Images in XML sitemap are always linked to base store in multisite Images in XML sitemap are always linked to base store in multistore May 29, 2018
@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed mm18nl labels Jun 1, 2018
@StevenGuapaBV StevenGuapaBV self-assigned this Jun 2, 2018
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 2, 2018
@StevenGuapaBV
magento#15588
7b8fe3d 
Added the appEmulation to get the correct image Url for the generated sitemaps. Context had incorrect Url data.
@StevenGuapaBV StevenGuapaBV mentioned this issue Jun 2, 2018
Merged
4 tasks
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 2, 2018
@StevenGuapaBV
magento#15588 Refactor for code neatness Travis CI.
498047c 
 48 | ERROR | [x] Opening parenthesis of a multi-line function call must be the last content on the line
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 3, 2018
@StevenGuapaBV
magento#15588 Fixed incorrect image urls sitemap
83ad777 
Change for travisCI
@okorshenko okorshenko removed the mm18nl label Jun 5, 2018
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 6, 2018
@StevenGuapaBV
magento#15588 Fixed incorrect image urls in multistore xml sitemap
6a490a8 
placed the stop Emulation in a finally. Now it will always be executed.
dmanners added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 6, 2018
@dmanners
magento#15588: Remove extra line from if
f1dd4e8
@VladimirZaets
Copy link
Contributor

Hi @dvershinin. Thank you for your report.
The issue has been fixed in #15689 by @StevenGuapaBV in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.6 release.

@VladimirZaets VladimirZaets added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 7, 2018
magento-engcom-team added a commit that referenced this issue Jun 7, 2018
@magento-engcom-team
ENGCOM-1866: #15588 Fixed incorrect image urls in multistore xml site…
ec41e34 
…map #15689

 - Merge Pull Request #15689 from StevenGuapaBV/magento2:2.2-develop
 - Merged commits:
   1. 7b8fe3d
   2. 498047c
   3. 63ed864
   4. 83ad777
   5. 6a490a8
   6. f1dd4e8
   7. b7f8d28
magento-engcom-team pushed a commit that referenced this issue Jun 7, 2018
ENGCOM-1866: #15588 Fixed incorrect image urls in multistore xml site…
b39e534 
…map #15689
@StevenGuapaBV StevenGuapaBV mentioned this issue Jun 7, 2018
Open
4 tasks
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 7, 2018
@StevenGuapaBV
magento#15588
d5bb4d0 
Added the appEmulation to get the correct image Url for the generated sitemaps. Context had incorrect Url data.
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 7, 2018
@StevenGuapaBV
magento#15588 Refactor for code neatness Travis CI.
6ab9c55 
 48 | ERROR | [x] Opening parenthesis of a multi-line function call must be the last content on the line
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 7, 2018
@StevenGuapaBV
magento#15588 Fixed incorrect image urls sitemap
9d256d9 
Change for travisCI
StevenGuapaBV added a commit to StevenGuapaBV/magento2 that referenced this issue Jun 7, 2018
@StevenGuapaBV
magento#15588 Fixed incorrect image urls in multistore xml sitemap
b24905c 
placed the stop Emulation in a finally. Now it will always be executed.
StevenGuapaBV pushed a commit to StevenGuapaBV/magento2 that referenced this issue Jun 7, 2018
@dmanners @StevenGuapaBV
magento#15588: Remove extra line from if
b4ff77e
@mage2pratik mage2pratik mentioned this issue Jul 14, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @dvershinin. Thank you for your report.
The issue has been fixed in #16813 by @mage2pratik in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Aug 10, 2018
magento-engcom-team added a commit that referenced this issue Aug 10, 2018
@magento-engcom-team
ENGCOM-2666: [Forwardport] #15588 Fixed incorrect image urls in multi…
ba8ea23 
…store xml sitemap #16813

 - Merge Pull Request #16813 from mage2pratik/magento2:2.3-develop-PR-port-15689
 - Merged commits:
   1. 04d4bb0
   2. d845518
   3. 547f6fd
   4. f422401
   5. e11be00
   6. 25010d4
   7. 65ccd39
magento-engcom-team pushed a commit that referenced this issue Aug 10, 2018
ENGCOM-2666: [Forwardport] #15588 Fixed incorrect image urls in multi…
32c2a19 
…store xml sitemap #16813
@lano-vargas lano-vargas mentioned this issue Dec 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StevenGuapaBV StevenGuapaBV

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dvershinin @okorshenko @VladimirZaets @StevenGuapaBV @magento-engcom-team