[Forwardport] #15588 Fixed incorrect image urls in multistore xml sitemap #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.3 develop
…view level (use default = yes)
…view level (use default = yes)
…ustom source model in the adminhtml doesn't render selected value
…umn outside of screen when... magento#15746
…umn outside of screen when... magento#15746
Accepted Public Pull Requests: - magento#15853: Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar) - magento#15695: Fixed a couple of typos (by @dverkade) - magento#15833: [Forwardport] Format the javascript code magento#10 (by @chirag-wagento) - magento#15755: [Forwardport] Error 500 in Module Manager (by @vijay-wagento) - magento#15794: [Forwardport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento) - magento#15809: [Forwardport] fix: support multiple minisearch widget instances (by @DanielRuf) - magento#15558: Fixes in catalog component blocks [2.3-develop] (by @mhauri) - magento#15572: [Forwardport] Docblock typo fixes (by @rogyar) - magento#15748: [Forwardport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @vijay-wagento) - magento#15745: [Forwardport] Fix method name (typo) (by @vijay-wagento) - magento#15746: [Forwardport] Resolved : UI Component listing action column outside of screen when... (by @vgelani) - magento#15692: Fix minor issues in ui export converter classes (by @dmytro-ch) - magento#15649: [Forwardport] Fixes in config module (by @mhauri) - magento#15540: fix for Wrong price amount on product page magento#11717 (by @HirokazuNishi) Fixed GitHub Issues: - magento#15192: Module Manager module grid is not working Magento 2.2.4 (reported by @jignesh-baldha) has been fixed in magento#15755 by @vijay-wagento in 2.3-develop branch Related commits: 1. 486f7a7 2. 1b5d1d1 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15794 by @hitesh-wagento in 2.3-develop branch Related commits: 1. 9fa6425 - magento#14153: UI Component listing action column outside of screen when too many columns (reported by @milansimek) has been fixed in magento#15746 by @vgelani in 2.3-develop branch Related commits: 1. 365bfb4 - magento#11717: Wrong price amount on product page (reported by @HirokazuNishi) has been fixed in magento#15540 by @HirokazuNishi in 2.3-develop branch Related commits: 1. cf05a84 2. 67a2038
…he cache issue for currencies with no symbol
[TSG] Upporting for 2.3 (pr21) (2.3.0)
…5921 - Merge Pull Request magento#15921 from DanielRuf/magento2:2.3-develop-PR-port-15871 - Merged commits: 1. 4d03776
- Merge Pull Request magento#15912 from NamrataChangani/magento2:2.3-develop-PR-port-15825 - Merged commits: 1. 3782793
…ets. magento#15911 - Merge Pull Request magento#15911 from NamrataChangani/magento2:2.3-develop-PR-port-15795 - Merged commits: 1. fdaf7cb
…e currencies with no symbol magento#15903 - Merge Pull Request magento#15903 from dmytro-ch/magento2:fix/2.3-cache-issue-for-currencies-with-no-symbol - Merged commits: 1. 23d76ed
…e currencies with no symbol magento#15903
Accepted Public Pull Requests: - magento#15903: [Forwardport] Complete the fix for cache issue due to the currencies with no symbol (by @dmytro-ch) - magento#15911: [Forwardport] Remove double semicolon from the style sheets. (by @namratachangani) - magento#15912: [Forwardport] Fixed set template syntax issue (by @namratachangani) - magento#15921: [Forwardport] chore: remove unused less import (by @DanielRuf) - magento#15867: [Forwardport] Update webapi.xml to fix typo (by @dmytro-ch) - magento#15847: [Up-port] check if order data is available to incl ec (by @torhoehn) Fixed GitHub Issues: - magento#12221: Google analytics pageview being triggered twice (reported by @alexhadley) has been fixed in magento#15847 by @torhoehn in 2.3-develop branch Related commits: 1. e46e5a5
Added the appEmulation to get the correct image Url for the generated sitemaps. Context had incorrect Url data.
48 | ERROR | [x] Opening parenthesis of a multi-line function call must be the last content on the line
Change for travisCI
placed the stop Emulation in a finally. Now it will always be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15689
Description
Added the appEmulation to get the correct image Url for the generated sitemaps. This was needed because the catalog image helper context had incorrect Url data.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist