[Forwardport] Correctly save Product Custom Option values

[JeroenVanLeusden]

Original Pull Request

#13569

Description

This occurred because the same value object is used for saving all values. After the save updateStoredData() is called and is used in prepareDataForUpdate().

magento2/lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php

Lines 718 to 733 in 3561b66

	protected function prepareDataForUpdate($object)
	{
	$data = $object->getData();
	foreach ($object->getStoredData() as $key => $value) {
	if (array_key_exists($key, $data) && $data[$key] === $value) {
	unset($data[$key]);
	}
	}
	$dataObject = clone $object;
	$dataObject->setData($data);
	$data = $this->_prepareDataForTable($dataObject, $this->getMainTable());
	unset($data[$this->getIdFieldName()]);
	unset($dataObject);
	return $data;
	}

Fixed Issues (if relevant)

1. Custom option values do not save correctly #5067: Custom option values do not save correctly

Manual testing scenarios

1. Install module ReachDigital_CustomOption.zip
2. An extra column as added to the Product Custom Options (http://cloud.h-o.nl/pP3N).
3. Uncheck all Changes Appearance checkboxes and save product.
4. Only the first checkbox is saved.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @JeroenVanLeusden. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.