Custom option values do not save correctly

[samtay]

Certain permutations of product custom options are impossible to save. For example,

1. First save a product with a custom option dropdown of two values with differing fields:
   
2. Now try to save the second value to be identical to the first, like so:
   
3. Notice that many of the values are not saved correctly. For me, this time around only the SKU was problematic, but you will have problems saving any number of these fields.

This is because

• the abstract resource model generates the UPDATE query based on differences between the new data array being saved and the preexisting $object->storedData array. code reference
• the OptionValue model loops through setData commands to save multiple OptionValue instances, hence storedData property refers to the previously saved Value instance, which is set during the previous setData()->..->save() iteration. code reference

So, those two reasons result in any identical OptionValue fields not able to be saved consecutively, causing the bug shown in steps 1-3.

I think it is rather odd/lazy that the option value model does not have its own resource model.. it seems like a poor idea to just loop through $this->setData()->save() calls. But, if you want to fix this quickly, just issue a $this->load($this->getOptionTypeId()) before the save. This will set the proper storedData property onto the model.

[antboiko]

Hello @samtay , could you please advise me if you have any errors upon saving the product with identical values in custom option? What Magento version are you using?

Thanks,
Anton.

[samtay]

No, see the above code references, this fails silently. Occurs on latest version.

[antboiko]

@samtay thanks for the details, I've created internal ticket MAGETWO-54516 to investigate this issue.

Best,
Anton.

[ttribeiro]

I have a similar problem. I edit the price of the option and do not save the price correctly.

Before Save

After Save

[yutv]

Can anyone from magento tell when this bug will be fixed? Really guys, you have had 1+ year to fix it but this bug still exists in your recent 2.2 release.

Here is hotfix - just modify Magento\Catalog\Model\Product\Option\Value::saveValues method:

1. add $clone = clone $this; after foreach
2. use $clone instead of $this in the foreach body.

[magento-engcom-team]

@samtay, thank you for your report.
We've created internal ticket(s) MAGETWO-54516 to track progress on the issue.

[yutv]

Here is a module with clone based workaround mentioned in my previous comment:
composer require orange35/magento2-custom-option-value-save-handler

[VladimirZaets]

Hi @samtay. Thank you for your report.
The issue has been fixed in #13569 by @JeroenVanLeusden in 2.2-develop branch
Related commit(s):

• d7f6baa1f20492a43ef76d32cb32be8b5f4b903d
• cb304dbdc9520528cacc77e214901a5ddb7a25fa
• 0b3fd22abb39e1f3aa802204e4c17df4c268a090

The fix will be available with the upcoming 2.2.6 release.

[magento-engcom-team]

Hi @samtay. Thank you for your report.
The issue has been fixed in #16838 by @JeroenVanLeusden in 2.3-develop branch
Related commit(s):

• 955fbf2b92cee5336489c0fdede4d862dee275fd
• db95d8ab1dee5030a3d592f9ecdea117b6b34a1f

The fix will be available with the upcoming 2.3.0 release.