Update catalog custom options with same SKU placed one-after-one. #17622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with Catalog Custom Options I found that if you're need to have two already existing custom options values (it's important, because it's not reproducing when you're adding new option values) placed one after one with the same SKU, you can't do this, because when you saving product, Magento update only first option value properly, second option value didn't have those changes after save.
I investigated and found that it happens because all custom options values are saved thru only one object, and as saving goes via cycle, Magento everytime compares option value that we currently save in this iteration with previously saved object data, which placed in storedData property.
Fixed issues
#5067
Manual testing scenarios
Expected result:
Changed will have the same SKU
Actual result:
We see changes in only first option, second option SKU is not updated.
Contribution checklist