Skip to content

Update catalog custom options with same SKU placed one-after-one. #17622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update catalog custom options with same SKU placed one-after-one. #17622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9116ab2
Catalog module fixes
arendarenko Aug 15, 2018
876bab8
Catalog module fixes
arendarenko Aug 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 34 additions & 18 deletions app/code/Magento/Catalog/Model/Product/Option/Value.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Magento\Catalog\Pricing\Price\BasePrice;
use Magento\Catalog\Pricing\Price\CustomOptionPriceCalculator;
use Magento\Catalog\Pricing\Price\RegularPrice;
use Magento\Catalog\Model\Product\Option\ValueFactory;

/**
* Catalog product option select type model
Expand Down Expand Up @@ -72,13 +73,19 @@ class Value extends AbstractModel implements \Magento\Catalog\Api\Data\ProductCu
private $customOptionPriceCalculator;

/**
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
* @var ValueFactory
*/
private $valueFactory;

/**
* @param \Magento\Framework\Model\Context $context
* @param \Magento\Framework\Registry $registry
* @param \Magento\Catalog\Model\ResourceModel\Product\Option\Value\CollectionFactory $valueCollectionFactory
* @param \Magento\Framework\Model\ResourceModel\AbstractResource $resource
* @param \Magento\Framework\Data\Collection\AbstractDb $resourceCollection
* @param array $data
* @param CustomOptionPriceCalculator|null $customOptionPriceCalculator
* @param \Magento\Framework\Model\ResourceModel\AbstractResource|null $resource
* @param \Magento\Framework\Data\Collection\AbstractDb|null $resourceCollection
* @param array $data
* @param CustomOptionPriceCalculator|null $customOptionPriceCalculator
* @param \Magento\Catalog\Model\Product\Option\ValueFactory|null $valueFactory
*/
public function __construct(
\Magento\Framework\Model\Context $context,
Expand All @@ -87,12 +94,14 @@ public function __construct(
\Magento\Framework\Model\ResourceModel\AbstractResource $resource = null,
\Magento\Framework\Data\Collection\AbstractDb $resourceCollection = null,
array $data = [],
CustomOptionPriceCalculator $customOptionPriceCalculator = null
CustomOptionPriceCalculator $customOptionPriceCalculator = null,
ValueFactory $valueFactory = null
) {
$this->_valueCollectionFactory = $valueCollectionFactory;
$this->customOptionPriceCalculator = $customOptionPriceCalculator
?? \Magento\Framework\App\ObjectManager::getInstance()->get(CustomOptionPriceCalculator::class);

$this->valueFactory = $valueFactory
?? \Magento\Framework\App\ObjectManager::getInstance()->get(ValueFactory::class);
parent::__construct(
$context,
$registry,
Expand Down Expand Up @@ -208,18 +217,25 @@ public function saveValues()
$option = $this->getOption();

foreach ($this->getValues() as $value) {
$this->isDeleted(false);
$this->setData($value)
->setData('option_id', $option->getId())
->setData('store_id', $option->getStoreId());

if ((bool) $this->getData('is_delete') === true) {
if ($this->getId()) {
$this->deleteValues($this->getId());
$this->delete();
$valueModel = $this->valueFactory->create();

$valueModel->setData(
$value
)->setData(
'option_id',
$option->getId()
)->setData(
'store_id',
$option->getStoreId()
);

if ((bool) $valueModel->getData('is_delete') === true) {
if ($valueModel->getId()) {
$this->deleteValues($valueModel->getId());
$valueModel->delete();
}
} else {
$this->save();
$valueModel->save();
}
}

Expand Down