Iterator cannot be used with foreach by reference #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at line 28, I remove the reference that is used inside the `foreach`. First and foremost this works with PHP 5.5+ but breaks on HHVM as part of the list of inconsistencies in PHP 5 https://github.com/facebook/hhvm/blob/master/hphp/doc/inconsistencies#L37-L43 I know the for the meantime Magento2 doesn't support yet HHVM but I think removing this reference on `foreach` will make this code compatible on future releases of PHP
|
duplicate of #1739 closing this pull request now |
okorshenko
pushed a commit
that referenced
this pull request
Nov 28, 2017
Public Pull Requests #12328 9742: Default welcome message returns after being deleted #9742 by @RomaKis #12253 New validation: 3bytes characters filter (4 bytes characters cannot be stored using UTF8) by @KarlDeux #12133 Fix for issue 12127: Single quotation marks are now decoded properly in admin attribute option input fields by @erfanimani #11389 Attribute category_ids issue by @manuelson Fixed Public Issues #9742 Default welcome message returns after being deleted #12058 Can't save emoji in custom product options #12127 Apostrophe in attribute option value in admin is not handled properly #11341 Attribute category_ids issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at line 28, I remove the reference that is used inside the
foreach.First and foremost this works with PHP 5.5+ but breaks on HHVM as part of the list of inconsistencies in PHP 5
https://github.com/facebook/hhvm/blob/master/hphp/doc/inconsistencies#L37-L43
I know the for the meantime Magento2 doesn't support yet HHVM but I think removing this reference on
foreachwill make this code compatible on future releases of PHP