Fix for ProductLink - setterName was incorrectly being set

[insanityinside]

Fix for ProductLink - setterName was incorrectly being set to an ucfirst instead of converting to camel case, which doesn't work as expected on attributes with underscores in their names.

To replicate, add a custom product link attribute in an extension that has an underscore in it. The normal expected setter routines in camel case do not work.

[magento-engcom-team]

Hi @insanityinside. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-2875 has been created to process this Pull Request

[insanityinside]

Update for pull request #17773 - now using SimpleDataObjectConverter::snakeCaseToUpperCamelCase to maintain uniformity, and catching a second instance of the same issue in a related class.

The Codacy/PR Quality Review doesn't like the static function use. I based the new code on the existing code in lib/internal/Magento/Generator/ExtensionAttributesGenerator.php . If there is a different preferred way to do this, please advise.

[magento-engcom-team]

Hi @insanityinside. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.