[Forwardport] Fix for ProductLink - setterName was incorrectly being set #17924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rst instead of converting to camel case, which doesn't work for models with underscores
…:snakeCaseToUpperCamelCase to maintain uniformity, and catch an additional case where the same issue occurred
magento-engcom-team
added
Partner: Krish TechnoLabs
partners-contribution
Contributor
|
Hi @mage2pratik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Contributor
|
Hi @mage2pratik , I'm closing this PR as a duplicate for #17772 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#17773
Fix for ProductLink - setterName was incorrectly being set to an ucfirst instead of converting to camel case, which doesn't work as expected on attributes with underscores in their names.
To replicate, add a custom product link attribute in an extension that has an underscore in it. The normal expected setter routines in camel case do not work.