-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sitemap grid render incorrect base urls for multiple stores #18000
Conversation
Hi @nntoan. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team give me test instance |
Hi @nntoan. Thank you for your request. I'm working on Magento instance for you |
Hi @nntoan, here is your new Magento instance. |
Hi @sidolov, thank you for the review. |
Hi @nntoan. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
In
Magento/Sitemap/Block/Adminhtml/Grid/Renderer/Link.php
, we've created new instance for\Magento\Sitemap\Model\Sitemap
. That lead to$sitemap->getStoreId()
isNULL
all the time, thesitemap.xml
generated still using correct store id because of we load$sitemap
instance from the collection which retrieve data directly from the database.So to fix this issue, we should set the store id for the current sitemap object based on store id retrieved from the current row.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist