[Forwardport] Fix sitemap grid render incorrect base urls for multiple stores #18228
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#18000
Description
In
Magento/Sitemap/Block/Adminhtml/Grid/Renderer/Link.php
, we've created new instance for\Magento\Sitemap\Model\Sitemap
. That lead to$sitemap->getStoreId()
isNULL
all the time, thesitemap.xml
generated still using correct store id because of we load$sitemap
instance from the collection which retrieve data directly from the database.So to fix this issue, we should set the store id for the current sitemap object based on store id retrieved from the current row.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist